New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Pin fetch polyfill to 3.0 UMD distributable #9795

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Sep 11, 2018

This should be included in a 3.8 final release.

This pull request seeks to resolve an issue where the fetch polyfill is no longer usable in Internet Explorer 11. This was due to the fact that we had never pinned the version of polyfill we consume, thus when its latest 3.0.0 release included breaking changes to the default build targetting JavaScript modules, not supportable in IE11.

The changes here target the IE-compatible UMD build, and also pin to the 3.0.0 version to avoid future issues.

Testing instructions:

Verify that saving works as expected in Internet Explorer and your preferred browser.

Based on our hashing of vendor scripts, I do not expect that an existing downloaded/cached copy should need to be deleted.

@youknowriad

LGTM 👍

@aduth aduth merged commit c408929 into master Sep 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/ie11-whatwg-fetch branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment