Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Removing wrapper div from the categories block #9798
Previously, the categories block was rendered inside a div, while other list-based blocks (archives, latest posts, list, etc.) were not. This update removes the div wrapper for consistency.
Previously, this block would render like this:
But this change updates that to:
We still need the wrapper div if this is shown as a dropdown, so this doesn't effect that. Seems like a simple change, and doesn't seem to require any css updates.
referenced this pull request
Sep 11, 2018
Thanks, @tofumatt — I agree that this seems like it'd be a very small fraction of themes. If anything, I've mostly heard from theme authors who dislike that these are inconsistent.
Sep 11, 2018
1 check passed
@ZebulanStanphill I think the difference here is that if the order of the categories were to change, there would be no change in meaning. However, changing the order of comments would change the way they're interpreted, since comments may reply to each other or provide context as a discussion continues.
(Emphasis is mine)