New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tooling: Include block serialization default parser in plugin #9799

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Sep 11, 2018

This should be included in a final 3.8 release.

Fixes #9791
Related: #8083

This pull request seeks to resolve an issue where the new PHP parser introduced in #8083 was not included in the plugin distributable.

Testing instructions:

Run npm run package-plugin. Ensure that the generated ZIP includes packages/block-serialization-default-parser/parser.php.

Verify there are no other non-included PHP files contained in packages:

find packages -type f -name "*.php"
@mcsf

This comment has been minimized.

Show comment
Hide comment
@mcsf

mcsf Sep 11, 2018

Contributor

Many thanks for jumping on this so quickly.

Contributor

mcsf commented Sep 11, 2018

Many thanks for jumping on this so quickly.

@mcsf

mcsf approved these changes Sep 11, 2018

Can confirm that the built plugin works when interacting with a third-party plugin which calls the PHP parser, whereas it didn't before.

@aduth aduth merged commit 5febf46 into master Sep 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the fix/9791-build-include-parser-php branch Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment