New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Image Block: Link Settings - None has a redundant URL field #9805

Merged
merged 2 commits into from Sep 18, 2018

Conversation

Projects
None yet
3 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Sep 11, 2018

Description

Fix: #8851

Simple PR to conditionally render the URL input field.

How has this been tested?

I added an image block, I went to the link settings in the block sidebar and I checked that when 'Link To' is 'None' the URL input field is not displayed when 'Link To' is not 'None' the URL input field is correctly displayed.

@chrisvanpatten

This comment has been minimized.

Show comment
Hide comment
@chrisvanpatten

chrisvanpatten Sep 11, 2018

Contributor

This has been driving me slightly crazy; I always click the Link URL field before remembering that it's disabled. Thanks for this 👍

Contributor

chrisvanpatten commented Sep 11, 2018

This has been driving me slightly crazy; I always click the Link URL field before remembering that it's disabled. Thanks for this 👍

@talldan

This looks good to me @jorgefilipecosta. I've just added a commit to use the already defined constant instead of a string.

@jorgefilipecosta jorgefilipecosta added this to the 4.0 milestone Sep 18, 2018

@jorgefilipecosta jorgefilipecosta merged commit f9ea5be into master Sep 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/Image-Block-Link-Settings-None-has-a-redundant-URL-field branch Sep 18, 2018

@jorgefilipecosta

This comment has been minimized.

Show comment
Hide comment
@jorgefilipecosta

jorgefilipecosta Sep 18, 2018

Member

Thank you for the review and for the commit @talldan!

Member

jorgefilipecosta commented Sep 18, 2018

Thank you for the review and for the commit @talldan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment