New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Image Block: Link Settings - None has a redundant URL field #9805

merged 2 commits into from Sep 18, 2018
Jump to file or symbol
Failed to load files and symbols.
+1 −1
Diff settings


Just for now

Viewing a subset of changes. View all

Use constant value instead of string

  • Loading branch information...
talldan committed Sep 18, 2018
commit 5fb9ce57335cdb13a3e50df9e3f5699bc05bb4a2
@@ -350,7 +350,7 @@ class ImageEdit extends Component {
options={ this.getLinkDestinationOptions() }
onChange={ this.onSetLinkDestination }
{ linkDestination !== 'none' && (
{ linkDestination !== LINK_DESTINATION_NONE && (
label={ __( 'Link URL' ) }
value={ href || '' }
ProTip! Use n and p to navigate between commits in a pull request.