New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments in transforms object of quote block #9806

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@ZebulanStanphill
Contributor

ZebulanStanphill commented Sep 11, 2018

Description

There were some comments in the Quote block index.js with inconsistent formatting, confusing sentences, and some typos. This PR improves them to better follow WordPress JavaScript coding standards and makes them more readable.

Note that I would have change the comments to use multi-line comment syntax, but I vaguely recall there being a reason not to do that in Gutenberg, and I have noticed that multiple single-line comments seems to be the convention in Gutenberg.

See also: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/#comments

@jorgefilipecosta

LGTM 👍 Thank you for this improvements @ZebulanStanphill!

@jorgefilipecosta jorgefilipecosta merged commit b43f318 into WordPress:master Sep 13, 2018

2 checks passed

codecov/project 49.02% remains the same compared to a0dfb14
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta added this to the 3.9 milestone Sep 13, 2018

@ZebulanStanphill ZebulanStanphill deleted the ZebulanStanphill:update/quote-block-code-comment-improvements branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment