New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new default block icon #9813

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented Sep 12, 2018

This updates the default block icon to match the new style and dimensions.

This updates the default icon, the icon your new block gets if you don't add your own icon:

screen shot 2018-09-12 at 10 08 11

Would appreciate a sanity check on the tests.

Add new default block icon
This updates the default block icon to match the new style and dimensions.

@jasmussen jasmussen added this to the 3.9 milestone Sep 12, 2018

@jasmussen jasmussen self-assigned this Sep 12, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Sep 12, 2018

@youknowriad

LGTM 👍

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Sep 12, 2018

Contributor

These are the failing tests:

screen shot 2018-09-12 at 10 43 24

screen shot 2018-09-12 at 10 43 29

I'm assuming that's the intermittently failing test that passes sometimes. Race condition?

In any casek I'll try and restart a couple of times.

Contributor

jasmussen commented Sep 12, 2018

These are the failing tests:

screen shot 2018-09-12 at 10 43 24

screen shot 2018-09-12 at 10 43 29

I'm assuming that's the intermittently failing test that passes sometimes. Race condition?

In any casek I'll try and restart a couple of times.

@jasmussen jasmussen merged commit 024e767 into master Sep 12, 2018

2 checks passed

codecov/project 49.02% (+0%) compared to 77ff8e6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the add/new-default-block-icon branch Sep 12, 2018

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Sep 12, 2018

Contributor

Thanks, much better :)

Contributor

mtias commented Sep 12, 2018

Thanks, much better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment