New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the close, chevrons, and ellipsis icons #9814

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented Sep 12, 2018

This applies the beginnings of a grid to the icons in the right side of the editor.

This is either a complement to, or a replacement for #9784.

Before:

screen shot 2018-09-12 at 11 29 05

After:

screen shot 2018-09-12 at 11 28 58

Look closely. Closelier. The ellipsis, x and down chevron are aligned.

Align the close, chevrons, and ellipsis icons
This applies the beginnings of a grid to the icons in the right side of the editor.

@jasmussen jasmussen added this to the 3.9 milestone Sep 12, 2018

@jasmussen jasmussen self-assigned this Sep 12, 2018

@jasmussen jasmussen requested review from karmatosed and WordPress/gutenberg-core Sep 12, 2018

@talldan

Looks good to me

@mtias

mtias approved these changes Sep 12, 2018

@mtias mtias merged commit 7eb1252 into master Sep 12, 2018

2 checks passed

codecov/project 49.02% remains the same compared to 024e767
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtias mtias deleted the polish/align-close-button branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment