New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTML Document for finding iframe in embed previews #9827

Merged
merged 2 commits into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@notnownikki
Member

notnownikki commented Sep 12, 2018

Description

Fix for concern highlighted in #9500 (comment)

How has this been tested?

Embed a tweet, embed a youtube video, and check the video has an aspect ratio CSS class applied, and the tweet does not.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

@notnownikki notnownikki requested a review from aduth Sep 12, 2018

@notnownikki notnownikki added this to the 3.9 milestone Sep 12, 2018

Show outdated Hide outdated packages/block-library/src/embed/index.js Outdated
@aduth

aduth approved these changes Sep 12, 2018

Thanks 👍 LGTM

@notnownikki notnownikki merged commit fe70f02 into master Sep 12, 2018

2 checks passed

codecov/project 48.96% remains the same compared to 555f656
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notnownikki notnownikki deleted the fix/embed-iframe-query-with-htmldocument branch Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment