New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add simplified block grammar spec to handbook #9837

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
3 participants
@mcsf
Contributor

mcsf commented Sep 12, 2018

Description

Add docs/grammar.md, a document auto-generated since #6116 containing a simplified specification of the Gutenberg block grammar, to the Gutenberg Handbook.

How has this been tested?

Changes to the handbook aren't very testable beforehand. Once these changes are merged and applies, the expectation is that:

Types of changes

Documentation.

@mcsf mcsf added this to the 3.9 milestone Sep 12, 2018

@mcsf mcsf requested review from pento and mtias Sep 12, 2018

@pento

pento approved these changes Sep 13, 2018

📖

@pento pento merged commit 1c68241 into master Sep 13, 2018

2 checks passed

codecov/project 48.96% remains the same compared to 00d0104
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pento pento deleted the add/docs-manifest-block-grammar branch Sep 13, 2018

@pento

This comment has been minimized.

Show comment
Hide comment
@pento

pento Sep 13, 2018

Member

I had to make a couple of tweaks to the docs importer: https://meta.trac.wordpress.org/changeset/7668

Member

pento commented Sep 13, 2018

I had to make a couple of tweaks to the docs importer: https://meta.trac.wordpress.org/changeset/7668

@mcsf

This comment has been minimized.

Show comment
Hide comment
@mcsf

mcsf Sep 13, 2018

Contributor

I had to make a couple of tweaks to the docs importer

Thanks!

Contributor

mcsf commented Sep 13, 2018

I had to make a couple of tweaks to the docs importer

Thanks!

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Sep 14, 2018

Member

When I run npm run docs:build, it removes the "grammar" entry from manifest.json.

Member

aduth commented Sep 14, 2018

When I run npm run docs:build, it removes the "grammar" entry from manifest.json.

@mcsf

This comment has been minimized.

Show comment
Hide comment
@mcsf

mcsf Sep 18, 2018

Contributor

When I run npm run docs:build, it removes the "grammar" entry from manifest.json.

Oh, because I'm an idiot who hadn't realized root-manifest.json is the cool kids' place now. Fix in #10014.

Contributor

mcsf commented Sep 18, 2018

When I run npm run docs:build, it removes the "grammar" entry from manifest.json.

Oh, because I'm an idiot who hadn't realized root-manifest.json is the cool kids' place now. Fix in #10014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment