New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Flatten BlockListLayout into base BlockList #9847

Merged
merged 2 commits into from Sep 13, 2018

Conversation

Projects
None yet
3 participants
@aduth
Member

aduth commented Sep 12, 2018

This pull request seeks to refactor the base BlockList component to reinherit all behaviors which were previously split out into a separate BlockListLayout component.

Review notes:

The diff is misleading as to the amount of changes which actually took place here. I intentionally avoided making any changes except to move layout.js into index.js, merging what had previously existed in index.js as its wrapping withSelect into BlockListLayout's existing. Finally, BlockListLayout was renamed to BlockList.

Testing instructions:

Verify there are no regressions in the display of blocks in the visual editor block list, including with nested block content (Columns block).

@aduth aduth added the Code Quality label Sep 12, 2018

@jorgefilipecosta

I tested and I did not noticed any problem. I verified BlockListLayout was not exported outside wp.editor so I think this is ready to merge 👍

@aduth aduth merged commit e9d0c47 into master Sep 13, 2018

2 checks passed

codecov/project 48.96% (+<.01%) compared to 00d0104
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the refactor/block-list-layout branch Sep 13, 2018

@mtias mtias added this to the 3.9 milestone Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment