New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a11y/HTML validation issues #9853

Merged
merged 3 commits into from Sep 14, 2018

Conversation

Projects
None yet
4 participants
@tofumatt
Member

tofumatt commented Sep 13, 2018

Fixes #2375

Description

Fix HTML validation issues mentioned in #2375.

How has this been tested?

Snapshots updated after expected failures.

Tested locally and button (the main HTML change) appears fine in the editor.

@tofumatt tofumatt added this to the 3.9 milestone Sep 13, 2018

@tofumatt tofumatt requested review from afercia and WordPress/gutenberg-core Sep 13, 2018

@tofumatt tofumatt requested a review from WordPress/gutenberg-core Sep 13, 2018

@aduth aduth modified the milestones: 3.9, 4.0 Sep 13, 2018

@tofumatt tofumatt requested review from aduth and WordPress/gutenberg-core Sep 13, 2018

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Sep 13, 2018

Member

Okay, fixed that scrolling attribute TODO I forgot about. Ready for review now 😄

Member

tofumatt commented Sep 13, 2018

Okay, fixed that scrolling attribute TODO I forgot about. Ready for review now 😄

@youknowriad

LGTM 👍

@tofumatt tofumatt modified the milestones: 4.0, 3.9 Sep 14, 2018

@tofumatt tofumatt merged commit 57f98b2 into master Sep 14, 2018

2 checks passed

codecov/project 49.05% (+0.07%) compared to 7dbcadb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tofumatt tofumatt deleted the fix/2375-html-validation-errors branch Sep 14, 2018

@@ -193,7 +193,7 @@ class Sandbox extends Component {
<FocusableIframe
iframeRef={ this.iframe }
title={ title }
scrolling="no"

This comment has been minimized.

@aduth

aduth Sep 14, 2018

Member

Regression: #9920

@aduth

aduth Sep 14, 2018

Member

Regression: #9920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment