New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camelCase and cross-component class name #9895

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@johngodley
Contributor

johngodley commented Sep 14, 2018

Fixes camel case typo in tabIndex in the block comparison modal, and use a class name local to the component.

This fixes the points raised #7995 (comment)

How has this been tested?

Existing tests updated for new names.

Trigger an invalid block and pick 'compare block conversion' from the ellipsis menu. Verify that the modal title looks the same:

edit_post_ wordpress_latest _wordpress

As it looked before:

edit_post_ wordpress_latest _wordpress

Types of changes

Minor class and attribute change

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Fix camelCase and cross-component class name
Fix typo in tabIndex and use a class name local to the component

@johngodley johngodley added the Blocks label Sep 14, 2018

@johngodley johngodley added this to the 3.9 milestone Sep 14, 2018

@johngodley johngodley requested a review from WordPress/gutenberg-core Sep 14, 2018

@talldan

👍

@johngodley johngodley merged commit 51a0287 into master Sep 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@johngodley johngodley deleted the update/block-comparison branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment