New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactNative - Wire onEnter to `requestHTMLWithCursor` command in RichText #9907

merged 4 commits into from Sep 20, 2018


None yet
3 participants

daniloercoli commented Sep 14, 2018

This PR adds the proper code to the onEnter callback in RichText.
onEnter now calls the command requestHTMLWithCursor on the underlying native editor implementation.
Also introduces a new onHTMLContentWithCursor that handles the returning HTML editor content with the cursor in it.

Wire onEnter that now calls `requestHTMLWithCursor` command on the un…
…delying native editor.

Also introduce onHTMLContentWithCursor that handles the returning prop.

@SergioEstevao SergioEstevao self-requested a review Sep 20, 2018


Looking good!

@daniloercoli daniloercoli merged commit ce54f0a into master Sep 20, 2018

2 checks passed

codecov/project 48.79% (-0.01%) compared to 7c7e764
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Show comment
Hide comment

daniloercoli Sep 20, 2018


Thanks Sergio!


daniloercoli commented Sep 20, 2018

Thanks Sergio!

@daniloercoli daniloercoli deleted the rnmobile/wire-on-enter-callback branch Sep 20, 2018

@mtias mtias added this to the 4.0 milestone Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment