New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mobile: Space block layout on small screens < 600px #9922

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Sep 14, 2018

Description

This PR just applies a simple CSS change to make sure the space blocks works correctly on small screens (< 600px).

Fixes: #8853

How has this been tested?

I checked space blocks works correctly on small screens and that on other screens the design was unchanged.

Screenshots

Before:
image

After:
screen shot 2018-09-14 at 20 46 15

@jorgefilipecosta jorgefilipecosta self-assigned this Sep 14, 2018

@jorgefilipecosta jorgefilipecosta added this to the 4.0 milestone Sep 14, 2018

@jorgefilipecosta jorgefilipecosta requested a review from kjellr Sep 17, 2018

@jorgefilipecosta

This comment has been minimized.

Show comment
Hide comment
@jorgefilipecosta

jorgefilipecosta Sep 17, 2018

Member

Thank you for the review @kjellr, could you approve the PR?

Member

jorgefilipecosta commented Sep 17, 2018

Thank you for the review @kjellr, could you approve the PR?

@kjellr

kjellr approved these changes Sep 17, 2018

🚢

@kjellr

This comment has been minimized.

Show comment
Hide comment
@kjellr

kjellr Sep 17, 2018

Contributor

Thank you for the review @kjellr, could you approve the PR?

Oh right. 😄 Sorry about that. Thanks again!

Contributor

kjellr commented Sep 17, 2018

Thank you for the review @kjellr, could you approve the PR?

Oh right. 😄 Sorry about that. Thanks again!

@jorgefilipecosta jorgefilipecosta merged commit 0816e23 into master Sep 17, 2018

2 checks passed

codecov/project 48.64% remains the same compared to c57102a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/space-block-mobile branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment