New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-publish close button in other locales #9988

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Sep 18, 2018

Fixes #9972.

This PR makes it so the spacing that sits between the final confirm "Publish" button and the close button is a flex spacer. That means it behaves as an autosizing elastic element that has no minimum width, has a max width, and wants to be as big as it can.

In these screenshots I've painted the spacer red, but it's invisible in the actual PR.

screen shot 2018-09-18 at 09 37 50

screen shot 2018-09-18 at 09 38 05

The width the spacer desires is 52px, which is about the space it takes to overlay the confirm publish button on top of the pre-publish button, so if you like you can "double-click" to publish.

Fix post-publish close button in other locales
Fixes #9972.

This PR makes it so the spacing that sits between the final confirm "Publish" button and the close button is a flex spacer. That means it behaves as an autosizing elastic element that has no minimum width, has a max width, and wants to be as big as it can.

@jasmussen jasmussen added this to the 4.0 milestone Sep 18, 2018

@jasmussen jasmussen self-assigned this Sep 18, 2018

@jasmussen jasmussen requested a review from nosolosw Sep 18, 2018

@jasmussen jasmussen merged commit bee8b55 into master Sep 18, 2018

2 checks passed

codecov/project 48.8% remains the same compared to c28d2db
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/close-button-post-publish branch Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment