New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu item hover colors. #9989

Merged
merged 2 commits into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Sep 18, 2018

This fixes an issue where the "Manage Reusable Blocks" menu item had a blue hover color as the only item in the menu.

It also adds a consistent hover color for the rest.

Why was it blue, you ask? Because it's the first menu item that's a hyperlink to a separate page, the others are buttons.

Before:

screen shot 2018-09-18 at 09 45 18

After:

screen shot 2018-09-18 at 09 44 00

Fix menu item hover colors.
This fixes an issue where the "Manage Reusable Blocks" menu item had a blue hover color as the only item in the menu.

It also adds a consistent hover color for the rest.

@jasmussen jasmussen added this to the 4.0 milestone Sep 18, 2018

@jasmussen jasmussen self-assigned this Sep 18, 2018

@jasmussen jasmussen requested a review from youknowriad Sep 18, 2018

@jorgefilipecosta

jorgefilipecosta approved these changes Sep 18, 2018 edited

Works great on my tests 👍
I wonder if the new mixin menu-style__hover should also be used on

&:hover:not(:disabled):not([aria-disabled="true"]),

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Sep 19, 2018

Contributor

Added the hover color there, good idea.

Contributor

jasmussen commented Sep 19, 2018

Added the hover color there, good idea.

@jasmussen jasmussen merged commit 13bee70 into master Sep 19, 2018

2 checks passed

codecov/project 48.77% (-0.03%) compared to c28d2db
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/hover-colors branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment