New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom classNames for dynamic blocks #9995

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Sep 18, 2018

closes #9991 and closes #9929

This PR fixes a small regression where custom classes for dynamic blocks were not parsed properly after a save.

This was a conflict with a behavior considering removal of custom classes from markup as a valid operation even if the block comment includes a custom className. But blocks returning null don't have a wrapper to which the custom className is added which means we shouldn't remove the className property in that case.

Testing instructions

  • Repeat instructions in #9991

@youknowriad youknowriad added this to the 4.0 milestone Sep 18, 2018

@youknowriad youknowriad self-assigned this Sep 18, 2018

@youknowriad youknowriad requested review from johngodley, aduth and WordPress/gutenberg-core Sep 18, 2018

@johngodley

Verified that it fixes the problem and doesn't affect the previous custom class change 👍

@youknowriad youknowriad merged commit 7c7e764 into master Sep 18, 2018

2 checks passed

codecov/project 48.8% (+<.01%) compared to f874704
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/custom-class-dynamic-blocks branch Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment