Use terms instead of term

[dhruvkb]

Problem

In the search controller, when performing filtering for more than one value, we use an array of term queries instead of using terms.

openverse-api/api/catalog/api/controllers/search_controller.py

Lines 172 to 177 in 6cc0551

	filters = []
	for arg in search_params.data[serializer_field].split(","):
	_param = es_field or serializer_field
	args = {"name_or_query": "term", _param: arg}
	filters.append(Q(**args))
	method = getattr(s, behaviour)

Description

Replace the array of term queries with a singular term query. According to the ES docs, the terms query is functionally identical to term.

Additional context

For an example, a terms query is used just a few lines below in the same file, inside the _exclude_filtered function.

openverse-api/api/catalog/api/controllers/search_controller.py

Line 197 in 6cc0551

s = s.exclude("terms", provider=to_exclude)

Implementation

• 🙋 I would be interested in implementing this feature.

[ramadanomar]

raising_hand I would be interested in implementing this feature.

[krysal]

Fixed in #902.