Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix URL in API consumer docs #1002

Merged
merged 2 commits into from Nov 4, 2022
Merged

Fix URL in API consumer docs #1002

merged 2 commits into from Nov 4, 2022

Conversation

krysal
Copy link
Member

@krysal krysal commented Nov 4, 2022

Fixes

Prevents confusing errors like this reported in the Fixing WordPress Forums. The user was trying to register for a key following instructions but the API returned the following:

{
	"detail": "Method \"GET\" not allowed."
}

I tried to reproduce it and found this happens when missing the trailing slash in the endpoint.

Description

This PR fixes the docs URLs to prevent this from happening. Also includes some other minor docs changes to remove warnings when building sphinx docs (just sphinx-make).

Testing Instructions

just up and check http://localhost:50280/v1/#section/Register-and-Authenticate

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal requested a review from a team as a code owner November 4, 2022 18:09
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Nov 4, 2022
@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 📄 aspect: text Concerns the textual material in the repository labels Nov 4, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/1002

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!
I wonder if replacing "Method GET not allowed" with "Only POST method allowed" would make it easier to understand the error message.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finds!

Openverse PRs automation moved this from Needs review to Reviewer approved Nov 4, 2022
@krysal
Copy link
Member Author

krysal commented Nov 4, 2022

I wonder if replacing "Method GET not allowed" with "Only POST method allowed" would make it easier to understand the error message.

@obulat I'm not sure where that message is coming from, but I made the request with the POST method and still get that erroneous message, so the only fix I found at the moment is to fix the endpoint in the docs.

Thanks for the quick review both!

@krysal krysal merged commit 3b8a5b8 into main Nov 4, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Nov 4, 2022
@krysal krysal deleted the fix/api-consumer-docs branch November 4, 2022 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants