Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Update Airflow to 2.2.4 #372

Merged
merged 2 commits into from Feb 23, 2022
Merged

Update Airflow to 2.2.4 #372

merged 2 commits into from Feb 23, 2022

Conversation

AetherUnbound
Copy link
Contributor

Description

This PR updates Airflow to the latest version, v2.2.4. Unfortunately, this version does not yet support Python 3.10 (although that's happening soon! See: apache/airflow#19059).

I've moved the Airflow version to an argument at the top of the Airflow installation section - this should make it easier to find and update the version, rather than hunting through the Dockerfile to try and find it.

This also fixes some deprecations warnings regarding Airflow that were appearing in the test output.

Testing Instructions

  1. just build
  2. just test
  3. Run a DAG and verify that it works!

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner February 23, 2022 00:08
@AetherUnbound AetherUnbound added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟧 priority: high Stalls work on the project or its dependents labels Feb 23, 2022
@AetherUnbound AetherUnbound requested a review from a team February 23, 2022 00:08
@dhruvkb dhruvkb added this to Needs review in Openverse PRs Feb 23, 2022
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that the changes necessary here are so minimal. The new Airflow arg for the version is a nice improvement.

@AetherUnbound
Copy link
Contributor Author

The label check action hates when I submit a PR from the GitHub CLI 🙈

@AetherUnbound
Copy link
Contributor Author

AetherUnbound commented Feb 23, 2022

I do not understand... @dhruvkb do you have any idea what's going on here? The labels are correct but the check is still failing 🤔 Same with this PR! WordPress/openverse-api#530

@zackkrida zackkrida added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟧 priority: high Stalls work on the project or its dependents and removed 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Feb 23, 2022
@zackkrida
Copy link
Member

@AetherUnbound that's super weird! I tried re-running the action manually and it still failed! Removing and re-applying the labels in the GitHub UI seemed to fix it, however.

Openverse PRs automation moved this from Needs review to Reviewer approved Feb 23, 2022
Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@AetherUnbound AetherUnbound merged commit 69b2eb7 into main Feb 23, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Feb 23, 2022
@AetherUnbound AetherUnbound deleted the feature/airflow-2.2.4 branch February 23, 2022 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants