Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Retire Common Crawl module & DAGs #870

Merged
merged 6 commits into from Nov 22, 2022
Merged

Conversation

AetherUnbound
Copy link
Contributor

Fixes

Fixes WordPress/openverse#1375 by @AetherUnbound
Fixes WordPress/openverse#1547 by @AetherUnbound

Description

Based on #861 from @Pmeet

This pull request has made the following changes

  1. Retired the dags/commoncrawl module to retired folder
  2. Removes the associated tests
  3. Updates the README.md & env.template to remove any commoncrawl specific attributes
  4. Removes unused testing buckets
  5. Removes unused test files

Testing Instructions

  1. just recreate && just test
  2. just up -> verity the commoncrawl DAGs no longer show up in the list.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner November 16, 2022 02:49
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Nov 16, 2022
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟩 priority: low Low priority and doesn't need to be rushed labels Nov 16, 2022
@Pmeet
Copy link
Contributor

Pmeet commented Nov 16, 2022

Thank you for doing this @AetherUnbound

@AetherUnbound
Copy link
Contributor Author

Thank you for doing this @AetherUnbound

Thanks for contributing the original changes 😄

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice touch on updating the documentation to the past tense.

Thanks for your contribution as well @Pmeet!

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Openverse PRs automation moved this from Needs review to Reviewer approved Nov 22, 2022
Co-authored-by: Olga Bulat <obulat@gmail.com>
@AetherUnbound AetherUnbound merged commit dad3cb4 into main Nov 22, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Nov 22, 2022
@AetherUnbound AetherUnbound deleted the feature/retire-commoncrawl branch November 22, 2022 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

Remove non-essential buckets in development Retire Common Crawl DAGs
5 participants