Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove button styling from "no results" text #272

Merged
merged 3 commits into from Sep 30, 2021

Conversation

Kevan-Y
Copy link
Contributor

@Kevan-Y Kevan-Y commented Sep 28, 2021

Fixes

Fixes #215 by @zackkrida

Description

  • Added a noresult props to MetaSearchForm.vue, the parent component will pass a boolean(true/false if the query has 0 elements).
  • Remove the old no more image button.

If no more image:
image
If 0 image in query(no results):
image

Testing Instructions

  1. Search something e.g.spacexs
  2. Seach something to give no result e.g.spacexxxxxxxxxx

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Kevan-Y Kevan-Y requested a review from a team as a code owner September 28, 2021 13:39
@dhruvkb dhruvkb added this to Needs review in Openverse Sep 28, 2021
@Kevan-Y
Copy link
Contributor Author

Kevan-Y commented Sep 28, 2021

Hi, I think I added the string for no-results-title in src/locales/en.json. I am not sure if it is the right way to update this string. Is it possible to guide me through? Thanks

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect 👍

@krysal krysal added 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix labels Sep 30, 2021
@krysal
Copy link
Member

krysal commented Sep 30, 2021

Great work @Kevan-Y! I rebased to get the updates of the main branch and fixed the paths in the openverse.pot file (we just discovered this issue here, it will be treated separately). Thank you!

Openverse automation moved this from Needs review to Reviewer approved Sep 30, 2021
@krysal krysal merged commit d52a388 into WordPress:main Sep 30, 2021
Openverse automation moved this from Reviewer approved to Done! Sep 30, 2021
@dhruvkb dhruvkb removed this from Done! in Openverse Oct 3, 2021
@dhruvkb dhruvkb added this to In progress in Openverse PRs via automation Oct 3, 2021
@dhruvkb dhruvkb moved this from In progress to Merged! in Openverse PRs Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

[Bug] Remove button styling from "no results" text
3 participants