Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add header icons #604

Merged
merged 1 commit into from Jan 14, 2022
Merged

Add header icons #604

merged 1 commit into from Jan 14, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 14, 2022 •
edited

Fixes

Related to #462 by @zackkrida

Description

This PR is created to reduce the number of files to review in the Content switcher PR :)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🌟 goal: addition Addition of new feature 🕹 aspect: interface Concerns end-users' experience with the software labels Jan 14, 2022
@obulat obulat requested a review from a team as a code owner January 14, 2022 05:23
@obulat obulat self-assigned this Jan 14, 2022
@dhruvkb dhruvkb added this to Needs review in Openverse PRs Jan 14, 2022
Openverse PRs automation moved this from Needs review to Reviewer approved Jan 14, 2022
@obulat obulat merged commit 815c7bd into redesign Jan 14, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Jan 14, 2022
@obulat obulat deleted the add/icons branch January 14, 2022 13:39
zackkrida added a commit that referenced this pull request Jan 14, 2022
@zackkrida @krysal
@obulat @sarayourfriend @dhruvkb
Openverse Redesign (#478)
5594e69 
* Update figma links in README

* Search results title (#577)

* Fix ci tests by restoring scopedSlots param in search results title spec

* Fix search result title casing

* Updated load more button (#578)

* Update `content-types` test with load more button changes

* VHeader (#488)

* Add VHeader stub
Rename VSearchBar and VSearchButton and move to VHeader
Add VLogoLoader to VHeader and adjust header styles

* Extract search route handling into composable, set Logo loading when fetching

* Update pnpm lockfile

* Add VFilterButton (#489)

Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Zack Krida <zackkrida@pm.me>

* Add searchbar to header (#491)

Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Zack Krida <zackkrida@pm.me>

* Update references to `InputField` to point to `VInputField` (#586)

* New 404 page (#583)

Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>

Co-authored-by: Zack Krida <zackkrida@pm.me>
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>

* Fix video tab

The media store query.mediaType is null for video, so it's not possible to use it as a key to look up results in the store

* Fix filters e2e tests by opening the sidebar

* Fix openverse.pot after-merge problems

* Fix e2e tests

* Show a generated artwork when the audio thumbnail is absent (#600)

* Fix single result back links

* Fix photo detail test

* Fix photo-details test

* Combine layouts into a single default (#599)

* Add header icons (#604)

* Fix error when `<rect>` dimensions are negative (#605)

* Add `VContentLink` component (#560)

Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Olga Bulat <obulat@gmail.com>

* Prevent unsupported media types causing header errors

* Better video tab fix

* Remove sample audio data (#571)

Co-authored-by: Krystle Salazar <krystle.salazar@ciens.ucv.ve>
Co-authored-by: Olga Bulat <obulat@gmail.com>
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
zackkrida added a commit that referenced this pull request Jan 21, 2022
@zackkrida @krysal
@obulat @sarayourfriend @dhruvkb
All results grid (#618)
f9f549b 
* Update figma links in README

* Search results title (#577)

* Fix ci tests by restoring scopedSlots param in search results title spec

* Fix search result title casing

* Updated load more button (#578)

* Update `content-types` test with load more button changes

* VHeader (#488)

* Add VHeader stub
Rename VSearchBar and VSearchButton and move to VHeader
Add VLogoLoader to VHeader and adjust header styles

* Extract search route handling into composable, set Logo loading when fetching

* Update pnpm lockfile

* Add VFilterButton (#489)

Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Zack Krida <zackkrida@pm.me>

* Add searchbar to header (#491)

Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Zack Krida <zackkrida@pm.me>

* Update references to `InputField` to point to `VInputField` (#586)

* New 404 page (#583)

Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>

Co-authored-by: Zack Krida <zackkrida@pm.me>
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>

* Fix video tab

The media store query.mediaType is null for video, so it's not possible to use it as a key to look up results in the store

* Fix filters e2e tests by opening the sidebar

* Fix openverse.pot after-merge problems

* Fix e2e tests

* Show a generated artwork when the audio thumbnail is absent (#600)

* Fix single result back links

* Fix photo detail test

* Fix photo-details test

* Combine layouts into a single default (#599)

* Add header icons (#604)

* Fix error when `<rect>` dimensions are negative (#605)

* Default to all from the homepage; init

* Add `VContentLink` component (#560)

Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Olga Bulat <obulat@gmail.com>

* Prevent unsupported media types causing header errors

* Better video tab fix

* Fix homepage test

* Remove sample audio data (#571)

* Modify "fetchState" mutations to support ALL_MEDIA

* All_MEDIA state working except for SET_MEDIA

* all media state init

* UI suppoort for media count

* wip

* ugh

* Mobile box layout adjustments

* Fix image clicks

* Content links

* Add debugging comment

* Remove dead code

* Result rounded corners

* Update src/utils/srand.js

* Focus states

* Small styling improvements to image grid title and horizontal spacing

* Refactor fetching for all media (#621)

* Refactor all fetching to use getters more

* Disable failing tests

* Revert index/key rename in image cell v-for

Co-authored-by: Zack Krida <zackkrida@pm.me>

* Add a wrapper to FETCH_MEDIA to simplify fetching all content (#640)

Add a wrapper to FETCH_MEDIA to simplify fetching all content

* Double number of skeleton boxes

* Progress

* Remove unused filter display component

* Set query when using filters

* Fix tests

* truncate audio box text

Co-authored-by: Krystle Salazar <krystle.salazar@ciens.ucv.ve>
Co-authored-by: Olga Bulat <obulat@gmail.com>
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zackkrida zackkrida zackkrida approved these changes

@dhruvkb dhruvkb dhruvkb approved these changes

Assignees

@obulat obulat

Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents
Projects
No open projects
Openverse PRs
  
Merged!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@obulat @zackkrida @dhruvkb