Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove catalog/requirements_tooling.txt #1844

Closed
sarayourfriend opened this issue Apr 20, 2023 · 2 comments · Fixed by #1856
Closed

Remove catalog/requirements_tooling.txt #1844

sarayourfriend opened this issue Apr 20, 2023 · 2 comments · Fixed by #1856
Assignees
@krysal
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Openverse

Comments

@sarayourfriend
Copy link
Contributor

Problem

This file appears to no longer be needed as pre-commit installation is handled by the monorepo.

Description

@AetherUnbound @stacimc can y'all confirm whether this issue is valid? Blocked until verification.

Remove the unneeded catalog/requirements_tooling.txt file.
@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users ⛔ status: blocked Blocked & therefore, not ready for work 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Apr 20, 2023
@openverse-bot openverse-bot added this to Backlog in Openverse Apr 20, 2023
@dhruvkb
Copy link
Member

dhruvkb commented Apr 20, 2023 •
edited

I agree with removing it, considering it's only purpose was to install pre-commit, which is now handled by the monorepo management. However, it is being referenced in the catalog's justfile, so that will also need to be dropped.

openverse/catalog/justfile

Lines 51 to 52 in 10ea15a

install *args: check-py-version
python -m pip install -r requirements_tooling.txt -r requirements_dev.txt

@AetherUnbound
Copy link
Contributor

Yep, it can definitely be removed! It had more dependencies initially I think but all of that has been moved to pre-commit so it can be jettisoned 😄

@AetherUnbound AetherUnbound removed the ⛔ status: blocked Blocked & therefore, not ready for work label Apr 20, 2023
@krysal krysal mentioned this issue Apr 20, 2023
Merged
5 tasks
@krysal krysal self-assigned this Apr 20, 2023
Openverse automation moved this from Backlog to Done! Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krysal krysal

Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Openverse Backlog
Archived in project
Openverse
  
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add catalog/recreate just command and remove a file WordPress/openverse
4 participants
@krysal @AetherUnbound @dhruvkb @sarayourfriend