Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Slack ping when PR is marked ready for review #115

Merged
merged 5 commits into from Dec 3, 2021
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Dec 3, 2021

Description

This PR extends the Slack workflow to also run when a draft PR is marked ready for review.

Testing Instructions

GitHub Actions are very hard to test. Reading the code very carefully is the only way.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added this to In progress in Openverse PRs Dec 3, 2021
@dhruvkb dhruvkb added 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase labels Dec 3, 2021
@dhruvkb dhruvkb marked this pull request as ready for review December 3, 2021 12:08
@dhruvkb dhruvkb requested a review from a team as a code owner December 3, 2021 12:08
@dhruvkb dhruvkb moved this from In progress to Needs review in Openverse PRs Dec 3, 2021
Copy link
Member Author

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we cannot test, here are some references:

Comment on lines +28 to +29
pr_status: ${{ github.event.pull_request.draft && ' draft ' || ' ' }}
pr_icon: ${{ github.event.pull_request.draft && ':pr-draft:' || ':pull-request:' }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference; alternatively, we can also set env vars using a run step

steps:
- name: Send Slack notification
- name: Send notification for new PR
if: github.event.action == 'opened'
Copy link
Member Author

@dhruvkb dhruvkb Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄 Incredible!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Openverse PRs automation moved this from Needs review to Reviewer approved Dec 3, 2021
@dhruvkb dhruvkb merged commit 5337b35 into main Dec 3, 2021
@dhruvkb dhruvkb deleted the undraft_ping branch December 3, 2021 17:13
Openverse PRs automation moved this from Reviewer approved to Merged! Dec 3, 2021
dhruvkb pushed a commit that referenced this pull request Feb 20, 2023
Replace deprecated `falcon.API` with `falcon.App`
dhruvkb pushed a commit that referenced this pull request Feb 20, 2023
Improve i18n pluralization for Russian
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants