New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send Slack ping when PR is marked ready for review #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we cannot test, here are some references:
pr_status: ${{ github.event.pull_request.draft && ' draft ' || ' ' }} | ||
pr_icon: ${{ github.event.pull_request.draft && ':pr-draft:' || ':pull-request:' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference; alternatively, we can also set env vars using a run
step
steps: | ||
- name: Send Slack notification | ||
- name: Send notification for new PR | ||
if: github.event.action == 'opened' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪄 Incredible!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Replace deprecated `falcon.API` with `falcon.App`
Improve i18n pluralization for Russian
Description
This PR extends the Slack workflow to also run when a draft PR is marked ready for review.
Testing Instructions
GitHub Actions are very hard to test. Reading the code very carefully is the only way.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin