Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a link to make design handbook #266

Merged
merged 1 commit into from Jun 24, 2022
Merged

Conversation

fcoveram
Copy link
Contributor

Description

I added a third point linking the Design handbook in the "Helpful links for new contributors", README.md file.

I added a third point linking the Design handbook in the "Helpful links for new contributors" section.
@fcoveram fcoveram requested a review from a team as a code owner June 24, 2022 18:44
@fcoveram fcoveram requested review from krysal and dhruvkb June 24, 2022 18:44
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Jun 24, 2022
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Jun 24, 2022
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Openverse PRs automation moved this from Needs review to Reviewer approved Jun 24, 2022
@zackkrida zackkrida merged commit b290bd5 into main Jun 24, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Jun 24, 2022
@zackkrida zackkrida deleted the adding-design-handbook-link branch June 24, 2022 22:41
dhruvkb added a commit that referenced this pull request Feb 20, 2023
dhruvkb pushed a commit that referenced this pull request Apr 14, 2023
* Remove operator_util.py

All of the functions were used in only one other file and were simple enough to either be moved to the DAG file itself or removed entirely.

* Move operators directly into update workflow DAG

* Move to retired folder

* Add retired folder to airflowignore

* Move update specific SQL functions to update_sql file in retired folder

* Fix tests

It's too much work to move the fixture out to a higher-level conftest file at this time, so we just import it into the file we need it in.

* Add README

* Move README, delete retired tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

4 participants