-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Submission: Team Social Cards #140
Comments
Love the giraffe! 😁 Not sure it fits this context in particular. A couple suggestions:
|
Here's a suggested edit, taking @beafialho's suggestions into account:
Here's how it turned out: Markup for all this is here: https://gist.github.com/kjellr/d58e732719d5336fbddf81f1a3070505 Let me know what you folks think! Image Credits: Portrait of a Woman (1910) by Egon Schiele. Public Domain. Portrait of a Woman (1910) by Egon Schiele. Public Domain. Portrait of a Woman (1910) by Egon Schiele. Public Domain. |
I like the changes. Great work! Moving the text out into a paragraph also fixes the spacing issue I was having with using it in a caption. |
This looks great, y'all nailed it. I think it's good to move over to the directory now 👍 |
This one is live! Thanks for contributing! https://wordpress.org/patterns/pattern/team-social-cards/ It looks like there's a bug that's not displaying the social links, so I'll keep the issue open to track that. |
Also, I figured out the icon color issue in the OP. When setting the Link Color for the Column block, WP/GB adds a It's noticable on the front-end but not the editor. That might need to be addressed upstream. |
Since some of the display issues appear to span across multiple patterns, I've opened a single issue to track them. I'll close this issue as resolved. |
Team/Company member sections are pretty common. This pattern uses the Columns block to create a four-column group of team cards with avatars and social links.
Notes: Either Twenty Twenty-One or Gutenberg is overriding the social icon color on the front end. In the editor, they are white (as they should be), but on the front end, they are black.
I could also probably find a better default image, but the giraffe might just be fine too. Not sure about including photos of real people (even under CC0) and whether we need an additional model release for such things.
Pattern Title
Team Social Cards
Pattern Categories
Columns
Screenshots
Image Credits
Public Domain / CC0 Images:
Block Markup
https://github.com/justintadlock/wporg-patterns/blob/master/columns-team-social-cards/pattern.html
The text was updated successfully, but these errors were encountered: