From 9b7059ecee3da3ea31edf7595c84a8e3419c43d9 Mon Sep 17 00:00:00 2001 From: Jason Adams Date: Fri, 17 Oct 2025 13:29:27 -0600 Subject: [PATCH] test: updates test to assure not failing by default --- tests/unit/Builders/PromptBuilderTest.php | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/tests/unit/Builders/PromptBuilderTest.php b/tests/unit/Builders/PromptBuilderTest.php index 38cba54d..de23054a 100644 --- a/tests/unit/Builders/PromptBuilderTest.php +++ b/tests/unit/Builders/PromptBuilderTest.php @@ -728,8 +728,9 @@ public function testUsingModelPreferenceWithProviderTupleModelInstanceThrowsExce public function testUsingModelPreferencePrefersFirstAvailableModelId(): void { $result = $this->createTestResult('Preferred by ID'); - $metadata = $this->createTextModelMetadataWithInputSupport('preferred-id'); - $model = $this->createMockTextGenerationModel($result, $metadata); + $secondaryMetadata = $this->createTextModelMetadataWithInputSupport('secondary-id'); + $preferredMetadata = $this->createTextModelMetadataWithInputSupport('preferred-id'); + $model = $this->createMockTextGenerationModel($result, $preferredMetadata); $this->registry->expects($this->once()) ->method('getProviderId') @@ -739,7 +740,7 @@ public function testUsingModelPreferencePrefersFirstAvailableModelId(): void $this->registry->expects($this->once()) ->method('findProviderModelsMetadataForSupport') ->with('test-provider', $this->isInstanceOf(ModelRequirements::class)) - ->willReturn([$metadata]); + ->willReturn([$secondaryMetadata, $preferredMetadata]); $this->registry->expects($this->once()) ->method('getProviderModel') @@ -766,8 +767,9 @@ public function testUsingModelPreferencePrefersFirstAvailableModelId(): void public function testUsingModelPreferenceWithProviderClassName(): void { $result = $this->createTestResult('Preferred with class name'); - $metadata = $this->createTextModelMetadataWithInputSupport('preferred-id'); - $model = $this->createMockTextGenerationModel($result, $metadata); + $secondaryMetadata = $this->createTextModelMetadataWithInputSupport('secondary-id'); + $preferredMetadata = $this->createTextModelMetadataWithInputSupport('preferred-id'); + $model = $this->createMockTextGenerationModel($result, $preferredMetadata); $this->registry->expects($this->once()) ->method('getProviderId') @@ -777,7 +779,7 @@ public function testUsingModelPreferenceWithProviderClassName(): void $this->registry->expects($this->once()) ->method('findProviderModelsMetadataForSupport') ->with('WordPress\AiClient\TestProvider', $this->isInstanceOf(ModelRequirements::class)) - ->willReturn([$metadata]); + ->willReturn([$secondaryMetadata, $preferredMetadata]); $this->registry->expects($this->once()) ->method('getProviderModel') @@ -804,8 +806,9 @@ public function testUsingModelPreferenceWithProviderClassName(): void public function testUsingModelPreferenceSkipsUnavailableModelId(): void { $result = $this->createTestResult('Fallback model result'); - $metadata = $this->createTextModelMetadataWithInputSupport('fallback-id'); - $model = $this->createMockTextGenerationModel($result, $metadata); + $otherMetadata = $this->createTextModelMetadataWithInputSupport('other-id'); + $fallbackMetadata = $this->createTextModelMetadataWithInputSupport('fallback-id'); + $model = $this->createMockTextGenerationModel($result, $fallbackMetadata); $this->registry->expects($this->once()) ->method('getProviderId') @@ -815,7 +818,7 @@ public function testUsingModelPreferenceSkipsUnavailableModelId(): void $this->registry->expects($this->once()) ->method('findProviderModelsMetadataForSupport') ->with('test-provider', $this->isInstanceOf(ModelRequirements::class)) - ->willReturn([$metadata]); + ->willReturn([$otherMetadata, $fallbackMetadata]); $this->registry->expects($this->once()) ->method('getProviderModel')