From b64917bc6573ec313ec7e7ee13bfee68a4f93860 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adam=20Zieli=C5=84ski?= <adam@adamziel.com>
Date: Sun, 3 May 2026 21:58:14 +0200
Subject: [PATCH] docs(xml): fix mismatched <strong> tags in pitfalls
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Round-2 audit found that two Footgun callouts in xml.md had unbalanced
<strong> tags — an artifact of an earlier "bold the lead sentence"
reformat that didn't account for the existing `<strong>#1:</strong>`
prefix. Each pitfall opened with `<strong>#N:</strong>` and then
re-emitted a closing `</strong>` at the end of the lead, so the
rendered HTML had one open and two closes:

  <p>Footgun: <strong>#1:</strong> namespace-aware methods…
                                  …not the prefix written in the tag.</strong>
                                                        ↑ stray close

Visible symptom: the bold span ran from `#1:` colon to the end of the
sentence, but the entire rest of the paragraph also rendered bold in
some browsers (the second `</strong>` close-without-open is forgiven
by the parser, so its effect depended on UA). Either way the lead
wasn't crisply bolded the way the other pitfall callouts on the page
are.

Fixed by dropping the `#N:` numbering (it added nothing — the
extractor already renders each pitfall as its own <aside>) and
moving the bold span to wrap a single lead sentence, matching the
style every other pitfall in the catalog uses now.

Verified by running the audit checks I did this round against every
component:
  - Class/interface lookups for every `use` statement → all resolve.
  - Method-existence checks for every `->method()` call in snippets
    → all exist.
  - Behavioural spot-checks on bytestream pull/peek/consume,
    polyfill hook ordering and apply_filters arg passing,
    encoding wp_is_valid_utf8 / wp_scrub_utf8, filesystem chroot,
    deflate/inflate round-trip, BlockParser key shape, MarkdownConsumer
    metadata, WXRWriter constructor, GitRepository::commit signature
    → all match the prose.

87/87 snippets still match captured stdout.
---
 bin/_docs_components/xml.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/_docs_components/xml.md b/bin/_docs_components/xml.md
index 09b3551d6..a4cf4c620 100644
--- a/bin/_docs_components/xml.md
+++ b/bin/_docs_components/xml.md
@@ -16,9 +16,9 @@ A streaming, namespace-aware XML processor in pure PHP. Read and modify huge fee
 
 <p>This design came from WordPress-scale documents such as WXR exports. A migration may only need to rewrite <code>wp:attachment_url</code> values or bump a feed attribute, so the processor optimizes for targeted cursor edits instead of a full validating XML stack.</p>
 
-<p>Footgun: <strong>#1:</strong> namespace-aware methods use the namespace name declared in <code>xmlns</code>, not the prefix written in the tag.</strong> In WXR, <code>get_attribute( 'wp', 'status' )</code> looks for a namespace literally named <code>wp</code>; for the usual WXR declaration you want <code>get_attribute( 'http://wordpress.org/export/1.2/', 'status' )</code>.</p>
+<p>Footgun: <strong>Namespace-aware methods use the namespace URI, not the prefix written in the tag.</strong> In WXR, <code>get_attribute( 'wp', 'status' )</code> looks for a namespace literally named <code>wp</code>; for the usual WXR declaration you want <code>get_attribute( 'http://wordpress.org/export/1.2/', 'status' )</code>.</p>
 
-<p>Footgun: <strong>#2:</strong> in streaming mode <code>next_tag()</code> can return false because input ran out, not because the document ended.</strong> Check <code>is_paused_at_incomplete_input()</code> before assuming you're done.</p>
+<p>Footgun: <strong>In streaming mode <code>next_tag()</code> can return false because input ran out, not because the document ended.</strong> Check <code>is_paused_at_incomplete_input()</code> before assuming you're done.</p>
 
 ## Bump every price in a catalog