Fix block validation on WordPress 6.2 #272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes block validation failing on WordPress 6.2, allowing posts to publish despite validation errors in blocks.
Why
While working on #271 to make e2e tests compatible with WP 6.2, one test failed for a valid reason related to production code:
togglePublishSidebar()was added in WordPress 6.3 and doesn't exist in 6.2. The error broke the promise chain before it could returnhasError = true. This caused the validation to silently fail, allowing posts with invalid blocks to be published.How
Checking if
togglePublishSidebarexists before calling it:Testing Instructions