Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_modules to filename checks #9

Closed
wants to merge 2 commits into from

Conversation

@ryelle
Copy link

ryelle commented Nov 10, 2014

This also prevents scanning into node_modules and .sass-cache folders (but keeps the top-level folder for the filename check). See #4 for background.

@Otto42

This comment has been minimized.

Copy link
Member

Otto42 commented Nov 25, 2014

The change to 1b9630d is probably fine.

However, instead of 64402b1, would it make more sense to allow a user-defined file for ignores? Like tc-ignore or something? This same ignore code would only be in the plugin, not on the org uploader. Nothing will be ignored there.

@devinsays

This comment has been minimized.

Copy link

devinsays commented Nov 26, 2014

I think a user-defined ignore file would be good. That would definitely be more adaptable. Perhaps it could read/parse the .gitignore file?

@Otto42

This comment has been minimized.

Copy link
Member

Otto42 commented Feb 24, 2015

If you want to submit a patch to ignore files on a plugin only manner, I'll accept that, after feedback. This is too strong. It can't be in the checks themselves. The checks are identical on w.org and I want to keep them that way. Put it in the base files, not in the checks.

@Otto42 Otto42 closed this Feb 24, 2015
@Otto42

This comment has been minimized.

Copy link
Member

Otto42 commented Feb 24, 2015

I didn't mean to close that. Just need a more targeted patch.

@Otto42 Otto42 reopened this Feb 24, 2015
@retlehs

This comment has been minimized.

Copy link

retlehs commented Apr 27, 2015

@devinsays good idea. bower_components is another one that should be ignored, and is usually also found in a .gitignore

@Otto42

This comment has been minimized.

Copy link
Member

Otto42 commented Sep 10, 2015

No traction on this. If this is useful, let's define a generic approach, or a plugin specific thing that can read various ignore files.

@Otto42 Otto42 closed this Sep 10, 2015
@grantpalin

This comment has been minimized.

Copy link

grantpalin commented Dec 11, 2015

Also consider the case where packages are located elsewhere than the default - Bower can do this, not sure if NPM can also. A per-project file seems the best way to manage the ignores.

I'd be interested in toying with a solution to this. The initial issue has come up for me when testing plugins/themes which use NPM / Bower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.