New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twenty Nineteen as a Block-based Theme #4
Conversation
Awesome! Works for me. A couple notes:
-
Should we get into the habit of adding a readme with the steps to recreate the demo before merging? Basically it could just contain the steps you outlined in the PR. Also, there is one step I'd add to your current list: I've found that the theme needs to be activated first via the
Appearance > Themes
Panel, before you can actually successfully publish via the Customizer. -
The nav links + pages are created correctly for me. I tested locally with the following specs:
- php 7.3.2
- wp 5.3.2
- gutenberg 7.2.0
Yeah, we probably should. There's a https://make.wordpress.org/themes/2015/04/29/a-revised-readme/ Though many of these are just demos and not intended for the theme repo, we should probably still use that general format for consistency.
Ah, thanks. I'll add this. |
I did some digging into why button styles weren't looking right in the footer, and it was because block styles for Twenty Nineteen were previously scoped only to the |
Similar to the Twenty Twenty PR, I've gone ahead and simplified this PR down a bit. I've removed all starter content, except for the simple Home + Blog pages. (The blog page template is the easiest way to get the blog page working with blocks for now). I've also fixed a few visual bugs in the header too. Some of the smaller issues noted above are still present, but I think this is a pretty good start, and should be a candidate for merge once it's tested out. |
Yeah, I think we can add that in too. I'll work on that after we merge this. Thanks! |
This PR uses a similar approach to #2, but applies it to Twenty Nineteen. It's based on the demo content from the Twenty Nineteen theme demo, but implemented as a Block-based Theme. CSS is mostly just duplicated from Twenty Nineteen, but has a few small adjustments as noted in the code comments.
Basic steps for testing:
Gutenberg > Experiments
panel.Appearance > Themes
.You can compare to the Twenty Nineteen Demo site. It should look pretty similar.
Issues
This is still in very much in progress, so this is surely not an exhaustive list of issues:
Button styles don't match.Screenshots: