Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for submenu items #143
Yes! @allancole and I did not get a chance to implement this in the first draft we pushed up, but we should definitely support submenu items.
Here's the mockup for large screens:
I'd love to morph that into something that feels spacious and mobile-native for small screens:
Here's a GIF of that in action:
We also had the concept of a fixed mobile menu on scroll — not sure if we'll pursue that (I think the direction in that GIF feels more modern), but here it is in case it sparks more discussion:
I'm going to be doing some thinking about the menu in general, so all this may change just a little bit... But in general: Yes, we need submenu support.
That's a great point. Changing the direction seems like a simple solution, though we could even swap out the icon entirely if we wanted to.