Skip to content
This repository has been archived by the owner. It is now read-only.

Add support for submenu items #143

Closed
fabiankaegy opened this issue Oct 18, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@fabiankaegy
Copy link
Contributor

commented Oct 18, 2018

I'm not sure how they would fit in this menu but I think it would be sad for a core theme not to include this functionality. At leaset one level deep.
bildschirmfoto 2018-10-18 um 09 29 56

@kjellr

This comment has been minimized.

Copy link
Collaborator

commented Oct 18, 2018

Yes! @allancole and I did not get a chance to implement this in the first draft we pushed up, but we should definitely support submenu items.

Here's the mockup for large screens:

menu-desktop

I'd love to morph that into something that feels spacious and mobile-native for small screens:

menu-mobile-large

Here's a GIF of that in action:

menu-mobile

We also had the concept of a fixed mobile menu on scroll — not sure if we'll pursue that (I think the direction in that GIF feels more modern), but here it is in case it sparks more discussion:

screen shot 2018-10-18 at 8 44 19 am

I'm going to be doing some thinking about the menu in general, so all this may change just a little bit... But in general: Yes, we need submenu support. 👍

@fabiankaegy

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2018

I really like the design shown in the gif. 👍

@melchoyce

This comment has been minimized.

Copy link

commented Oct 19, 2018

One quick note on mobile — there's a bit of cognitive dissonance that happens when you click a down arrow, and the panel comes in from the side. It's a little disorienting at first. Maybe change the direction of the arrow, or the direction the panel comes in from?

@kjellr

This comment has been minimized.

Copy link
Collaborator

commented Oct 19, 2018

One quick note on mobile — there's a bit of cognitive dissonance that happens when you click a down arrow, and the panel comes in from the side. It's a little disorienting at first. Maybe change the direction of the arrow, or the direction the panel comes in from?

That's a great point. Changing the direction seems like a simple solution, though we could even swap out the icon entirely if we wanted to.

@designsimply designsimply changed the title Are there plans to add support for submenu items? Add support for submenu items Oct 19, 2018

@kjellr kjellr added this to the RC1 milestone Oct 23, 2018

@kjellr

This comment has been minimized.

Copy link
Collaborator

commented Oct 24, 2018

I'm going to close this issue, since submenu support has been added. #280 has been opened to implement submenu mobile styles.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.