Skip to content
This repository has been archived by the owner. It is now read-only.

Mobile Menu: Console errors when clicking on empty links #726

Closed
kjellr opened this issue Dec 11, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@kjellr
Copy link
Collaborator

commented Dec 11, 2018

When using the touch menu, I'm seeing frequent errors related to ariaItem.getAttribute and event.target.nextItem.matches. Those are logging console errors when their value is null:

screen shot 2018-12-11 at 8 48 48 am

To reproduce:

  • View a Twenty Nineteen site using the iOS, Firefox, or Chrome device simulators.
  • Click on a link that points to #.
  • Check the console for errors.

@kjellr kjellr added the bug label Dec 11, 2018

@kjellr kjellr added this to the 5.0.1 milestone Dec 11, 2018

@allancole

This comment has been minimized.

Copy link
Collaborator

commented Dec 12, 2018

Pretty sure this will get fixed when #721 is merged :-).

@kjellr

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 12, 2018

@allancole I'm actually seeing them in that branch, too.

@kjellr

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 10, 2019

We're in the process of closing down this GitHub repository now that the theme is merged into core, so I've migrated this issue over to Trac at the link below. I'm closing this issue a result. Please feel free to follow up in the new thread moving forward:

https://core.trac.wordpress.org/ticket/45903

Thanks!

@kjellr kjellr closed this Jan 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.