Skip to content
This repository has been archived by the owner. It is now read-only.

Footer closing div with no comment #63

Closed
asathoor opened this Issue Sep 12, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@asathoor
Copy link

asathoor commented Sep 12, 2016

The /div https://github.com/WordPress/twentyseventeen/blob/master/footer.php#L14 could have a comment, which div is closed here?

@LittleBigThing

This comment has been minimized.

Copy link

LittleBigThing commented Sep 12, 2016

</div><!-- #content -->

It is opened at the end of header.php

@asathoor

This comment has been minimized.

Copy link
Author

asathoor commented Sep 13, 2016

thanx, now it's in my forked version.

@grappler

This comment has been minimized.

Copy link
Member

grappler commented Sep 13, 2016

Would be good to update the title so that people know that the issue is about at first glance. Something like "Footer closing div without comment"

@asathoor asathoor changed the title /div Footer closing div with no comment Sep 14, 2016

@davidakennedy

This comment has been minimized.

Copy link
Collaborator

davidakennedy commented Sep 28, 2016

Thanks! This was updated here: 7cb718a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.