Skip to content
This repository has been archived by the owner. It is now read-only.

Social links placement for excerpts below the entry title #397

Closed
mtomas7 opened this issue Dec 18, 2015 · 4 comments
Closed

Social links placement for excerpts below the entry title #397

mtomas7 opened this issue Dec 18, 2015 · 4 comments

Comments

@mtomas7
Copy link

@mtomas7 mtomas7 commented Dec 18, 2015

Hello,

I noticed that plugins like Floating Social Bar places its icons also for top excerpt, please see image. This capture is of a single post.

clipboard01

Should the theme be changed to avoid this behavior or it is a plugin's fault?

Thank you!

@iamtakashi
Copy link
Contributor

@iamtakashi iamtakashi commented Dec 18, 2015

A default theme won't change because of a particular plugin :)

Jetpack sharing button has been adjusted to not show up there. I'm not saying the plugin should do the same but just FYI.

@iamtakashi iamtakashi closed this Dec 18, 2015
@brentlogan
Copy link

@brentlogan brentlogan commented Dec 18, 2015

I think this could have been an easy fix. In the function twentysixteen_excerpt, replace <?php the_excerpt(); ?> with

     <?php
        $my_excerpt = get_the_excerpt();
        echo $my_excerpt;
     ?>

Twenty Sixteen is admittedly using the excerpt in a ground-breaking fashion. A little backward compatibility is a good thing, IMHO.

@mtomas7
Copy link
Author

@mtomas7 mtomas7 commented Dec 22, 2015

Thank you for this fix, now I can use this approach in my theme! :)

P.S. and nobody got hurt by implementing this.

P.P.S. Default WP themes should show good example for other developers.

@brentlogan
Copy link

@brentlogan brentlogan commented Dec 22, 2015

Even if Twenty Sixteen is not modified, all is not lost: twentysixteen_excerpt has been written to be able to be overridden in a simple plugin. No editing of the theme files is necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.