Skip to content
This repository has been archived by the owner. It is now read-only.

What is the use of the Full Width Template? #185

Closed
yannickiki opened this issue Sep 10, 2019 · 3 comments · Fixed by #547
Closed

What is the use of the Full Width Template? #185

yannickiki opened this issue Sep 10, 2019 · 3 comments · Fixed by #547
Labels

Comments

@yannickiki
Copy link
Contributor

@yannickiki yannickiki commented Sep 10, 2019

I don't see any difference between Default Template and Full Width Template. Is it a leftover from Chaplin?

@andersnoren

This comment has been minimized.

Copy link
Contributor

@andersnoren andersnoren commented Sep 11, 2019

@yannickiki Thanks for posting the issue! I think there's an expectation for a full width template still (even if the block editor now allows for a lot of the modifications they've often been used for), so we probably want to include one. It seems like no styles are being applied to it currently though, like you say.

The full-width template should:

  • Remove the .thin class from the wrapping .post-inner element, so the content container extends to the width of the layout.
  • Remove the max-width values from .entry-content and .entry-content p, so they extend to the width of the container.
  • When we implement the .alignleft and .alignright classes with negative horizontal margins, positioning them outside the main content column (the pull quote in this image), we'll need to adjust those classes to make sure they don't extend outside the main content column on the full width template.
@LittleBigThing

This comment has been minimized.

Copy link
Contributor

@LittleBigThing LittleBigThing commented Sep 25, 2019

I have asked a similar question here: #497 (comment)

Also, do these styles still have to be applied?
Could we make the differences or the benefits using the template clear in some way?

@byalextran

This comment has been minimized.

Copy link
Contributor

@byalextran byalextran commented Sep 26, 2019

@andersnoren does #527 address .alignleft and .alignright as you described above?.

if so, and assuming my PR is valid, i think additional styling tweaks are needed.

Screen Shot 2019-09-25 at 22 23 03 PM

Screen Shot 2019-09-25 at 22 23 13 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.