Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New enhancement - Top/preheader toolbar #463

Open
paaljoachim opened this issue Sep 22, 2019 · 18 comments

Comments

@paaljoachim
Copy link

commented Sep 22, 2019

Hey

It would be nice to have a preheader toolbar area. To add specials, social menu or other things.
Thanks.

@nielslange

This comment has been minimized.

Copy link
Collaborator

commented Sep 22, 2019

Isn't that something that can easily be achieved via child theme or plugin, e.g. https://wordpress.org/plugins/top-bar

@mafzal9

This comment has been minimized.

Copy link

commented Sep 22, 2019

For cover page there should be an option to chose image overlay color in page.

@carolinan

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2019

@omphs are you not able to find the option in the customizer?

It has its own section, it is not under colors.

@mafzal9

This comment has been minimized.

Copy link

commented Sep 22, 2019

@omphs are you not able to find the option in the customizer?

It has its own section, it is not under colors.

yeah i changed the color using customizer. But it's a suggestion that if it could be in every page section then user have more flexibility to generate multi color pages.

@nielslange

This comment has been minimized.

Copy link
Collaborator

commented Sep 22, 2019

@omhps Would you mind creating a separate issue for this as it's not related to New feature suggestion - Top/preheader toolbar. 😀

@mafzal9

This comment has been minimized.

Copy link

commented Sep 22, 2019

@omhps Would you mind creating a separate issue for this as it's not related to New feature suggestion - Top/preheader toolbar. 😀

Sure @nielslange

@paaljoachim

This comment has been minimized.

Copy link
Author

commented Sep 23, 2019

Hey Niels. @nielslange
Yes. It can be created with a child theme or a plugin. For users who decide on using the new default theme it would be good to go through and notice which features would be helpful to include. If it is supposed to be a bare bones theme then including extras such as a preheader/top bar should not be included. It goes back to the vision for the theme. Hopefully it will be a worthy theme and not one that is rushed and could use more time then it seems to be getting. One could always move the theme to WP 5.4 if that is needed to be sure that it gets the treatment it needs.

@nielslange

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2019

@paaljoachim Thanks for your explanation. I see that @pattonwebz already added the label enhancement to this issue. Do you like to implement this feature and create a PR for it?

@paaljoachim

This comment has been minimized.

Copy link
Author

commented Sep 24, 2019

Thanks @nielslange

I would like to but my skills are in the UI/design area not in coding.
It also looks like it is too late.

@nielslange

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2019

@paaljoachim While it's too late for Beta 1 it might not be too late for Beta 2. What about if you create the mockup and write down the requirements and I implement it? 😉

@paaljoachim

This comment has been minimized.

Copy link
Author

commented Sep 24, 2019

The thought is here that we are adding widget areas to where we can place Gutenberg blocks.
That means a preheader could have opening hours, social menu and other things that are needed. It could use a background color that should be easy to add.

I am working on a mockup to show how it can look.

@paaljoachim

This comment has been minimized.

Copy link
Author

commented Sep 24, 2019

Here is an example.

Preheader-mockup

@andersnoren

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2019

Sorry guys, but this goes beyond post-beta fixes. I'm not saying having such an area would have been a bad idea, but we would have needed to have added it before the Beta 1 deadline.

@paaljoachim

This comment has been minimized.

Copy link
Author

commented Sep 24, 2019

I would suggest asking for more time to improve the theme. The more I dig into it the more I also see it needs design improvement.

@nielslange

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2019

@andersnoren That's why @pattonwebz labelled this issue as enhancement. Shouldn't we leave this issue open for later, in case we want to implement it once WP 5.3 had been shipped with Twenty Twenty?

@paaljoachim paaljoachim changed the title New feature suggestion - Top/preheader toolbar New enhancment suggestion - Top/preheader toolbar Sep 24, 2019
@paaljoachim paaljoachim changed the title New enhancment suggestion - Top/preheader toolbar New enhancement - Top/preheader toolbar Sep 24, 2019
@pattonwebz

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

I am happy to reopen this and label it as a tracking issue for the future.

@pattonwebz

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

I do feel like this kind of change is not something we should focus on during the beta 2 phase and if this is added it's likely to be added much later. Personally I feel like this is an idea child theme feature however let's keep discussions open if people have ideas to share or things to talk about :D

@paaljoachim

This comment has been minimized.

Copy link
Author

commented Sep 25, 2019

Should I close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.