Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on Theme Options Section #495

Closed
paaljoachim opened this issue Sep 24, 2019 · 1 comment · Fixed by #569

Comments

@paaljoachim
Copy link

commented Sep 24, 2019

I am taking a closer look at the text used in the Theme Options section.

Screen Shot 2019-09-24 at 09 03 22

"Settings for this theme"
Why is this there? Just above in the section heading it says Theme Options.

"Show search in header"
"Uncheck to hide the search in the header."
Uncheck and hide becomes in a sense a doble negative. What about "Check to show search in the header." Or better yet just remove the sentence. It is common practice to click a checkbox to do something. When the user clicks the checkbox they will instantly see the results.

On archive pages, posts show:
"Search results always show the summary."
This becomes confusing as it mentions the archive pages and posts and suddenly also mentions the search results. The line should just be removed.

Default selection is "Full text" it should be Summary.

Here is an alternative Theme Options section.

Twenty-Twenty-Theme-Options-Alternative

@andersnoren

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

"Settings for this theme"
Why is this there? Just above in the section heading it says Theme Options.

I think this text can be improved by changing it to something like "Settings specific to the Twenty Twenty theme". Without prior knowledge, "Theme Options" could be interpreted as options for themes in general, so I don't think a description clarifying the purpose of the panel is out of place here.

"Show search in header"
"Uncheck to hide the search in the header."

I agree that the description seems a bit superfluous here.

"On archive pages, posts show:"
"Search results always show the summary."

Same on this one. I'm guessing that many users interpret archive pages and search results pages as two different things, so the clarification probably creates more confusion than it prevents.

I disagree that "Summary" should be the default setting though, as almost all themes with a structure similar to Twenty Twenty show "Full text" on archive pages (including previous default themes). Changing that default in Twenty Twenty would create a lot of confusion among users.

@andersnoren andersnoren removed their assignment Sep 25, 2019
@nielslange nielslange self-assigned this Sep 26, 2019
nielslange added a commit to nielslange/twentytwenty that referenced this issue Sep 26, 2019
@nielslange nielslange added the Has PR label Sep 26, 2019
nielslange added a commit to nielslange/twentytwenty that referenced this issue Sep 26, 2019
nielslange added a commit to nielslange/twentytwenty that referenced this issue Sep 27, 2019
nielslange added a commit to nielslange/twentytwenty that referenced this issue Sep 27, 2019
andersnoren added a commit to nielslange/twentytwenty that referenced this issue Sep 27, 2019
andersnoren added a commit that referenced this issue Sep 27, 2019
* UPDATE #495: Adjust theme options page

* UPDATE/#495: Fix Travis CI issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.