Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting the cover template featured image size? #498

Open
paaljoachim opened this issue Sep 24, 2019 · 3 comments

Comments

@paaljoachim
Copy link

commented Sep 24, 2019

The cover template will take the featured image and cover the full page.
What about making it possible to change the height of the featured image?
So that the cover covers parts of the screen and not all of it.

Screen Shot 2019-09-24 at 10 09 09

Screen Shot 2019-09-24 at 10 16 46

As it would be nice with the option to have the featured image for instance cover the header area and down into the beginning content area and not the full page.

@andersnoren

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

I'm leaning towards this being a bit too granular to motivate an option of it's own. The change in behaviour can be accomplished pretty easily with Custom CSS or a child theme. I'm open to counterarguments though.

@andersnoren andersnoren removed their assignment Sep 25, 2019
@andersnoren andersnoren added the design label Sep 25, 2019
@boemedia

This comment has been minimized.

Copy link

commented Sep 25, 2019

In commercial theme's it's not uncommon to be able to adjust the height of the hero section. It would be great to have this setting in the customizer, where a height of 25, 50, 75% or full height could be selected, or custom. In the same way the boxed content often can be customized.

I wouldn't assume people using the WP default theme are all familiar with CSS, so I'd be carefull taking that as a starting point.

@joyously

This comment has been minimized.

Copy link

commented Sep 25, 2019

Looks like a header image to me. How often do themes allow different sizes of header images?
I think it's best to keep it simple and leave some room for enhancements in child themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.