Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of the front page of Twenty Twenty theme not using cover template #501

Closed
paaljoachim opened this issue Sep 24, 2019 · 3 comments · Fixed by #623

Comments

@paaljoachim
Copy link

commented Sep 24, 2019

Here is an example of Twenty Twenty theme not using the cover template but the default page template.

Notice the big Front page title and how much space it takes up. The standard page content using a Gutenberg paragraph and an image float has very little space below.

Twenty-Twenty-Front

A new suggestion. After some CSS modifications are added

Screen Shot 2019-09-24 at 13 08 48

It makes the Front page title smaller. It takes up less space below the header. Gutenberg content is wider.

@paaljoachim paaljoachim changed the title Example of the front page of Twenty Twenty them not using cover template Example of the front page of Twenty Twenty theme not using cover template Sep 24, 2019
@andersnoren

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

With the default background colors, the entry header has a bottom padding with the white background ("Header & Footer Background Color"), and the entry content has a top padding with the beige background color ("Background Color").

image

I think it would be a good idea to add a body class when those background color settings are set to the same color, and modify the spacing accordingly. In this scenario, that would mean removing the top padding of the entry content, bringing them closer together (similar to the spacing in the modified image you posted).

There's an issue with Image Blocks with the left and right alignment not being positioned correctly. They should be positioned to the left or right of the entry content column, like in the screenshot below. I'll create a separate issue for that.

image

As for the font-size of the post title, we'll have to agree to disagree :)

@andersnoren andersnoren removed their assignment Sep 25, 2019
@andersnoren andersnoren added the design label Sep 25, 2019
@andersnoren

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

After a discussion in the WordPress design slack, we decided that it would be a good idea to add a class to the body when the two background colors are the same, so the layout (especially padding and margins) can be adjusted when the colors are the same.

Assigning the adding of the body class to @aristath. I can modify the CSS when the class is in place.

aristath added a commit to aristath/twentytwenty that referenced this issue Sep 27, 2019
@aristath

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.