Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a trailing slash to home_url() #141

Merged
merged 2 commits into from Sep 12, 2019

Conversation

@audrasjb
Copy link
Contributor

commented Sep 9, 2019

Add a trailing slash to home_url() for consistency with other places where the function is used.

Fixes #132

Copy link
Member

left a comment

Perhaps using trailingslashit() instead?

@debabratakarfa

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

I think trailingslashit() primary use of this is for paths.

@carolinan carolinan merged commit 234306c into WordPress:master Sep 12, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
pattonwebz added a commit that referenced this pull request Sep 12, 2019
* Merging Develop into Master (#220)

* rename parts to template-parts

* Rename parts/modal-search.php to template-parts/modal-search.php

* Rename parts/page-header.php to template-parts/page-header.php

* Rename parts/classes/class-comment-walker.php to inc/classes/class-comment-walker.php

* Rename parts/classes/class-svg-icons.php to inc/classes/class-svg-icons.php

* Rename parts/classes/class-theme-customizer.php to inc/classes/class-theme-customizer.php

* Rename pagination.php to template-parts/pagination.php

* Rename inc/classes/class-comment-walker.php to classes/class-comment-walker.php

* Rename inc/classes/class-svg-icons.php to classes/class-svg-icons.php

* Rename inc/classes/class-theme-customizer.php to classes/class-theme-customizer.php

* PHPCS fixes

* More PHPCS fixes

* Fix remaining coding standards errors in functions.php

* Fix remaining errors and warnings from phpcs

* Must load entry-header after changing from page-header

* #183: Adjust font size (#226)

* Add styles for post pagination (#100)

* Add styles for the post pagination.

* Add nav and aria labels to menus (#209)

Add nav and aria labels to menus.
Partial fix for #73

* Add a trailing slash to home_url() (#141)

Add a trailing slash to home_url() for consistency with other places where the function is used.

* Add screen-reader-text to skip link

* Widget search input field should not be hidden (#169)

Make sure only the span inside the label for the search widget input field is hidden.

* Fix accent color not applying on social buttons (#229)

* Fix accent color not applying on social buttons

* #221: Fix hover issue (#228)

Adds color-accent-hover:hover

* Merge branch 'develop'

* Flip merge resolution on this one hunk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.