Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/use h1 in home template #24

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@audrasjb
Copy link
Contributor

commented Sep 6, 2019

H1 tag should ideally be used on both home and front-page cases.

Fixes #23

@senadir

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

I think 37a854b belongs to #18

other than that, LGTM

@joyously

This comment has been minimized.

Copy link

commented Sep 6, 2019

The other two commits are extra.
This PR does not address the H1 in index.php.

<h1 class="archive-title"><?php echo wp_kses_post( $archive_title ); ?></h1>

@audrasjb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

PR refreshed.

@audrasjb

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

Thanks @senadir for your check.
@joyously Thanks too, by the way I guess this one should be addressed in an other PR.

@joyously

This comment has been minimized.

Copy link

commented Sep 6, 2019

Really, it belongs together. See my comment in the issue.

@carolinan
Copy link
Contributor

left a comment

I agree that there are more places where the headings are incorrect,
-A homepage with a static page has two h1 then skips to h3 -but lets approve this PR for now, and we will be one small step closer.

@carolinan carolinan merged commit 02771fa into WordPress:master Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.