Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`TwentyTwenty_Customize` Class Rework #258

Merged
merged 10 commits into from Sep 17, 2019

Conversation

@acosmin
Copy link
Contributor

commented Sep 14, 2019

  • made the sanitize functions part of the class

Fix for #257

carolinan added 2 commits Sep 14, 2019
@acosmin acosmin changed the title Removed methods prefixes from `TwentyTwenty_Customize` `TwentyTwenty_Customize` Class Rework Sep 15, 2019
@acosmin

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

Removed type => theme_mod and settings => settingname as they are not needed.

@acosmin

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2019

@carolinan I think this can be merged :) so we can all work with the same options and avoid conflicts.

acosmin and others added 3 commits Sep 17, 2019
Copy link
Contributor

left a comment

Nice improvement, tests are good and looks good to me

@ianbelanger79 ianbelanger79 merged commit 425fdf1 into WordPress:master Sep 17, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@acosmin acosmin deleted the acosmin:customizer-file branch Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.