Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing roles to <nav> elements #693

Merged
merged 4 commits into from Oct 2, 2019

Conversation

@audrasjb
Copy link
Contributor

commented Oct 1, 2019

Adds missing navigation roles to <nav> elements.

Fixes: #462

Jb Jb
@andersnoren andersnoren requested a review from carolinan Oct 1, 2019
@carolinan

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

;P What happened to the header banner role?
https://github.com/WordPress/twentytwenty/blob/master/header.php#L33

carolinan and others added 2 commits Oct 1, 2019
@ianbelanger79 ianbelanger79 merged commit a7c8e5a into WordPress:master Oct 2, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.