Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add additional block patterns #204

Merged
merged 12 commits into from Nov 5, 2021
Merged

Add additional block patterns #204

merged 12 commits into from Nov 5, 2021

Conversation

kjellr
Copy link
Collaborator

@kjellr kjellr commented Nov 3, 2021 •
edited

This PR adds new patterns. Some are from #172, a few are new. Also closes #184.

Screenshots

General:

Screen Shot 2021-11-03 at 4 33 04 PM

Screen Shot 2021-11-03 at 4 33 14 PM

Screen Shot 2021-11-03 at 4 33 27 PM

Headers:

Screen Shot 2021-11-05 at 8 08 54 AM

Screen Shot 2021-11-05 at 8 09 56 AM

Pages:

Screen Shot 2021-11-05 at 8 57 47 AM

Screen Shot 2021-11-05 at 9 23 18 AM

@kjellr kjellr mentioned this pull request Nov 4, 2021
Closed
kjellr added a commit that referenced this pull request Nov 5, 2021
@kjellr
Remove changes from #204
44f060c
@kjellr kjellr requested a review from jffng November 5, 2021 13:23
@kjellr kjellr self-assigned this Nov 5, 2021
@kjellr kjellr added this to the Feature Freeze milestone Nov 5, 2021
@kjellr kjellr marked this pull request as ready for review November 5, 2021 13:24
jffng
jffng approved these changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are lovely and testing well visually.

One very minor comment, this LGTM. The blog posts layout with a right sidebar works nicely on mobile too because of the header, it makes sense for the sidebar to fall to the footer. Nice job! 👏

inc/patterns/page-sidebar-blog-posts-right.php Outdated Show resolved Hide resolved
@kjellr kjellr merged commit 88a1cc8 into trunk Nov 5, 2021
@kjellr kjellr deleted the add/new-patterns branch November 5, 2021 14:50
jffng added a commit that referenced this pull request Nov 5, 2021
@kjellr @jffng
Add more colorful header patterns, fix dark footer pattern (#211)
e91a0f8 
* Add new patterns

* Rename bird icon.

* Begin revising header patterns.

* Remove changes from #204

* Delete unused image.

* Fix footer color variable.

* Add colors to centered and social patterns.

* Change pattern titles to sentence case.

* Allow for left/right padding in the dark footer pattern.

* Remove navigationMenuId.

Co-authored-by: Jeff Ong <jonger4@gmail.com>
@kjellr kjellr mentioned this pull request Nov 15, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jffng jffng jffng approved these changes

Assignees

@kjellr kjellr

Labels
[Component] Block Patterns [Type] Enhancement New feature or request
Projects
None yet
Milestone
Feature Freeze
Development

Successfully merging this pull request may close these issues.

Provide a header pattern that uses a background image
2 participants
@kjellr @jffng