Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add default feed links to <head> #63

Closed

Conversation

audrasjb
Copy link
Contributor

@audrasjb audrasjb commented Oct 7, 2021

Just like any other bundled theme, Twenty Twenty-Two should insert posts and comments feed links to the <head> of the document by default :)

@kjellr
Copy link
Collaborator

kjellr commented Oct 8, 2021

This also seems like something that we should be able to cut out of the codebase for block themes. @youknowriad do you have any thoughts on this one?

@audrasjb
Copy link
Contributor Author

audrasjb commented Oct 8, 2021

This is not the case for WordPress themes, so it would be kinda weird to have it by default for block themes and not for "classic" themes isn't it?

@youknowriad
Copy link

I think we should take a look at the functions.php file of 2022 and potentially change the defaults for some of these theme supports for FSE themes (or themes with theme.json). What made sense as default for classic theme might not be true anymore in 2021. For instance, why does a theme still have to opt-in to HTML5 today. Why does it even need to be configurable.

I think we should take a look at all of these one by one and decide what makes most sense:

  • Make the theme support obsolete for FSE themes
  • Provide a theme.json config to replace it
  • opt-in or opt-out

Ideally, functions.php shouldn't be needed at all.

@audrasjb
Copy link
Contributor Author

audrasjb commented Oct 8, 2021

I'm ok with this, but is it going to happen and realistic and properly documented in time for 5.9? If yes I'd definitely say "yes" to this change. But it needs to be properly announced :)

If we can't have a complete solution for 5.9, then I think we'd better stay with the current implementation of "classic" themes at least for Twenty Twenty-Two :)

@kjellr kjellr added [Status] Needs Decision [Type] Gutenberg An upstream bug or feature request in Gutenberg labels Oct 10, 2021
@jffng
Copy link
Collaborator

jffng commented Oct 14, 2021

Since WordPress/gutenberg#35593 merged, shall we close this one?

@kjellr
Copy link
Collaborator

kjellr commented Oct 14, 2021

Yes, I think that makes sense. 👍

@kjellr kjellr closed this Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Status] Needs Decision [Type] Gutenberg An upstream bug or feature request in Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants