Skip to content
Permalink
Browse files

Twenty Nineteen: Make sure links are followed on touchend, not touchs…

…tart.

The theme's original navigation JavaScript was making it so all links on a site were immediately followed on touchstart when using a touch-enabled device. This update makes sure links are followed at touchend, to improve usability and menu behavior.

Props anevins, panchen, kjellr.
Fixes #45510.



git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44357 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information...
laurelfulford committed Dec 21, 2018
1 parent eb965c2 commit 0acb4ebc35f933585ec2c649ce07497f3c4c7f58
Showing with 1 addition and 11 deletions.
  1. +1 −11 src/wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js
@@ -219,19 +219,9 @@

var url = event.target.getAttribute( 'href' ) ? event.target.getAttribute( 'href' ) : '';

// If there’s a link, go to it on touchend
if ( '#' !== url && '' !== url ) {
window.location = url;

// Open submenu if url is #
} else if ( '#' === url && event.target.nextSibling.matches('.submenu-expand') ) {

if ( '#' === url && event.target.nextSibling.matches('.submenu-expand') ) {
openSubMenu( event.target );

// Prevent default touch events
} else {

event.preventDefault();
}
}

0 comments on commit 0acb4eb

Please sign in to comment.
You can’t perform that action at this time.