Skip to content
Permalink
Browse files

Accessibility: Add a default title for the media modal dialog.

Makes sure the media modal dialog `h1` heading isn't empty when custom media frames don't set a title. This is particularly important now that the media modal is an ARIA dialog, as the title is referenced by an `aria-labelledby` attribute to properly label the dialog.

Props donmhico, audrasjb.
Fixes #47612.


git-svn-id: https://develop.svn.wordpress.org/trunk@45925 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information...
afercia committed Sep 1, 2019
1 parent e2b68a4 commit 425d6fd92587f11e778c364918130cf2b813204f
Showing with 3 additions and 1 deletion.
  1. +2 −1 src/js/media/views/media-frame.js
  2. +1 −0 src/wp-includes/media.php
@@ -1,4 +1,5 @@
var Frame = wp.media.view.Frame,
l10n = wp.media.view.l10n,
$ = jQuery,
MediaFrame;

@@ -32,7 +33,7 @@ MediaFrame = Frame.extend(/** @lends wp.media.view.MediaFrame.prototype */{
Frame.prototype.initialize.apply( this, arguments );

_.defaults( this.options, {
title: '',
title: l10n.mediaFrameDefaultTitle,
modal: true,
uploader: true
});
@@ -3764,6 +3764,7 @@ function wp_enqueue_media( $args = array() ) {
$strings = array(
// Generic
'mediaFrameDefaultTitle' => __( 'Media' ),
'url' => __( 'URL' ),
'addMedia' => __( 'Add Media' ),
'search' => __( 'Search' ),

0 comments on commit 425d6fd

Please sign in to comment.
You can’t perform that action at this time.